[pve-devel] [PATCH storage v4 01/19] rbd: make monhost option optional

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Sep 5 14:59:30 CEST 2017


to allow differentiating between user-created external RBD storage
entries (WITH monhost), and those created and managed by pveceph
(without).

making monhost non-fixed allows easily opting into the managed behaviour via
'pvesm set STORAGE -delete monhost', but is also helpful for external clusters
(i.e., after adding or removing a monitor you need to update the monhost
parameter..)

adapt description accordingly.

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
changes since v3:
- dropped pveceph flag altogether
- adapted monhost description
- make monhost no longer fixed

changes since v2:
- combined patches 1 and 2

changes since v1:
- make parameter fixed
- adapted description for new behaviour

 PVE/Storage/RBDPlugin.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index 250ee7c..30f7696 100644
--- a/PVE/Storage/RBDPlugin.pm
+++ b/PVE/Storage/RBDPlugin.pm
@@ -258,7 +258,7 @@ sub plugindata {
 sub properties {
     return {
 	monhost => {
-	    description => "Monitors daemon ips.",
+	    description => "IP addresses of monitors (for external clusters).",
 	    type => 'string', format => 'pve-storage-portal-dns-list',
 	},
 	pool => {
@@ -284,7 +284,7 @@ sub options {
     return {
 	nodes => { optional => 1 },
 	disable => { optional => 1 },
-	monhost => { fixed => 1 },
+	monhost => { optional => 1},
 	pool => { optional => 1 },
 	username => { optional => 1 },
 	content => { optional => 1 },
-- 
2.11.0





More information about the pve-devel mailing list