[pve-devel] [PATCH manager v4 0/8] Display the SCSI controller type when adding a new disk

Emmanuel Kasper e.kasper at proxmox.com
Mon Oct 2 10:37:29 CEST 2017


Since we switched to the SCSI controller in the Wizard as the recommended controller
for hard disks (using VirtIO scsi in the backend) it was not clear for users
that they were actually using a paravirtualized driver.

An example of user confusion:
https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056
The problem was also seen in trainings.

changes since V3:

 * Patch 4: infer that we don't need VirtIO in the controller list, as 
 autoSelect is set to 'cdrom'.  I kept the 'autoSelect' function parameter, as
 I am not sure of the safety of changing the IDE bus position for CD ROM drives.
 * Patch 6: do not suspend change events, use temp variable to store SCSI type
 * Patch 7-8: fix long lines in commit log


Emmanuel Kasper (8):
  Do not use 'autoselect' as a boolean when preselecting a bus
  Remove unused noScsi parameter
  Save the components we found via down() in a variable for later reuse.
  Do not use the noVirtIO property to build the controller list
  Add a field to show which SCSI controller type we are currently using
  Update VM SCSI type based on iothread value when inside the wizard
  Update VM SCSI controller type after OS selection in Wizard
  Render full name of VirtIO Block controller

 www/manager6/form/BusTypeSelector.js    |  8 ++---
 www/manager6/form/ControllerSelector.js | 59 +++++++++++++++------------------
 www/manager6/qemu/CreateWizard.js       |  5 ---
 www/manager6/qemu/HDEdit.js             | 37 ++++++++++++++++-----
 www/manager6/qemu/OSDefaults.js         |  2 +-
 www/manager6/qemu/OSTypeEdit.js         | 10 +-----
 6 files changed, 60 insertions(+), 61 deletions(-)

-- 
2.11.0




More information about the pve-devel mailing list