[pve-devel] [PATCH manager] Reduce the number of translations needed

Dietmar Maurer dietmar at proxmox.com
Wed Jan 18 17:48:44 CET 2017


> >  	if (me.fwtype === 'node') {
> > -	    add_boolean_row('enable', gettext('Enable Firewall'), 1);
> > +	    add_boolean_row('enable', gettext('Enable') + ': ' +
> > gettext('Firewall'), 1);
> 
> I do not think this is good, because "Enable" and "Enable something" is 
> not the same, e.g. in german i would translate:
> 
> Enable: Aktivieren
> Enable something: Aktiviere etwas
> 
> so now it would go like this:
> 
> Aktivieren etwas
> 
> this not german.
> 
> i would propose something like this:
> 
> Ext.String.format(gettext("Enable {0}"), gettext("Firewall"))


Can we simple use: 

gettext('Enable Firewall') => gettext('Enable')

gettext('Enable DHCP') => 'DHCP'

gettext('Enable XXYYYZZZ') => 'XXYYYZZZ'


unless there is a real reason to use 'blah blah XXYYYZZZ blah' ...

Or is this to minimalistic?



More information about the pve-devel mailing list