[pve-devel] [PATCH container v4] close #1478: add check for unsupported config

Philip Abernethy p.abernethy at proxmox.com
Wed Aug 23 17:04:37 CEST 2017


Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
That suggestion evidently slipped my mind.
 src/PVE/API2/LXC/Status.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
index 89a2fca..7f754e5 100644
--- a/src/PVE/API2/LXC/Status.pm
+++ b/src/PVE/API2/LXC/Status.pm
@@ -177,6 +177,15 @@ __PACKAGE__->register_method({
 			PVE::LXC::Config->check_lock($conf);
 		    }
 
+		    if ($conf->{unprivileged}) {
+			my $uses_quota = 0;
+			PVE::LXC::Config->foreach_mountpoint($conf, sub {
+			    my ($ms, $mountpoint) = @_;
+			    die "Quotas are not supported by unprivileged containers.\n" if $mountpoint->{quota};
+			});
+
+		    }
+
 		    my $storage_cfg = cfs_read_file("storage.cfg");
 
 		    PVE::LXC::update_lxc_config($vmid, $conf);
-- 
2.11.0




More information about the pve-devel mailing list