[pve-devel] [PATCH RFC storage 4/4] fix #1123: modify NVME device path for SMART support
Fabian Grünbichler
f.gruenbichler at proxmox.com
Fri Sep 30 10:52:23 CEST 2016
seems like we need to drop the namespace part before calling
smartctl.
note that NVME devices require smartmontools >= 6.5
---
PVE/Diskmanage.pm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
index 29e07d1..12c742c 100644
--- a/PVE/Diskmanage.pm
+++ b/PVE/Diskmanage.pm
@@ -77,6 +77,10 @@ sub get_smart_data {
my $type;
my $returncode = 0;
+
+ $disk =~ s/n\d+$//
+ if $disk =~ m!^/dev/nvme\d+n\d+$!;
+
eval {
$returncode = run_command([$SMARTCTL, '-H', '-A', '-f', 'brief', $disk], noerr => 1, outfunc => sub{
my ($line) = @_;
@@ -135,6 +139,8 @@ sub get_smart_health {
return "NOT A DEVICE" if !assert_blockdev($disk, 1);
my $message;
+ $disk =~ s/n\d+$//
+ if $disk =~ m!^/dev/nvme\d+n\d+$!;
run_command([$SMARTCTL, '-H', $disk], noerr => 1, outfunc => sub {
my ($line) = @_;
--
2.1.4
More information about the pve-devel
mailing list