[pve-devel] qemu2.7: cpu hotplug && hot-unplug v1

[Alexandre DERUMIER]

>>I also wonder if it would make sense to run the backup code
>>inside its own thread? I guess this would make the code simpler.

Yes. It can have big advantage.

If it share the main qemu thread, this can make slowdown or qemu hang is backup process is hanging.

Not sure how it's implemented in qemu drive_backup ?






----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 12 Septembre 2016 16:42:06
Objet: Re: [pve-devel] qemu2.7: cpu hotplug && hot-unplug v1

> >>Due to scope rules in C The declaration of aio_context must be moved out 
> >>of the while block. I would suggest the following code then: 
> >>AioContext *aio_context = NULL; 
> 
> Yes, sure. I just post a basic sample ;) 

I also wonder if it would make sense to run the backup code 
inside its own thread? I guess this would make the code simpler.