[pve-devel] [PATCH manager 2/2] vzdump: make exclude-path from config file work again

[Wolfgang Bumiller]

> On March 4, 2016 at 3:53 PM Jean-Francois Dagenais <jeff.dagenais at gmail.com> wrote:
> 
> 
> 
> > On Mar 3, 2016, at 09:34, Jean-Francois Dagenais <jeff.dagenais at gmail.com> wrote:
> > 
> > Contrary to the docs (wiki, man page, etc.), the '/dir/.+' notation doesn't seem
> > to work here. If I put these instead in vzdump.conf: '/dir/*' then it works.
> > 
> > Same goes for rsync. I tested rsync separately at the cmd line.
> 
> Any word on this? Would you like me to send a patch fixing the doc?

The regex part is already updated AFAIK, but the "pid" vs ".pid" part is not, so
if you like, patches are welcome. (For me it's weekend break time now first ;-) )

> Also, this has been discussed in a prior thread, but I find it way more convenient to give tar and rsync the "--exclude-from=/etc/vzdump_exclude.conf" option, then fill one pattern per line. Way less cumbersome that one giant exclude line (you should see mine).
> 
> The plus of this is that both rsync and tar can accept the same vzdump_exclude.conf file since the syntax is the same.
> 
> I think this would make a great feature. The code could continue to support the current method for backwards compatibility.

If you're interested in adding this the option would have to be added to the schema
in pve-manager, and used in pve-container's VZDump module.
(Otherwise you can always just open a feature request on our bugzilla.)

> Do you have regression tests in place so the "exclude-path" functionality stays fixed over time?

not yet, unfortunately, we should probably bump up the priority of these...