[pve-devel] [PATCH manager 2/2] vzdump: make exclude-path from config file work again

[Jean-Francois Dagenais]

> On Mar 3, 2016, at 09:34, Jean-Francois Dagenais <jeff.dagenais at gmail.com> wrote:
> 
> Contrary to the docs (wiki, man page, etc.), the '/dir/.+' notation doesn't seem
> to work here. If I put these instead in vzdump.conf: '/dir/*' then it works.
> 
> Same goes for rsync. I tested rsync separately at the cmd line.

Any word on this? Would you like me to send a patch fixing the doc?

Also, this has been discussed in a prior thread, but I find it way more convenient to give tar and rsync the "--exclude-from=/etc/vzdump_exclude.conf" option, then fill one pattern per line. Way less cumbersome that one giant exclude line (you should see mine).

The plus of this is that both rsync and tar can accept the same vzdump_exclude.conf file since the syntax is the same.

I think this would make a great feature. The code could continue to support the current method for backwards compatibility.

Do you have regression tests in place so the "exclude-path" functionality stays fixed over time?

Cheers!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20160304/24874c74/attachment.sig>