[pve-devel] [PATCH 2/2] enable cache=unsafe for vma extract_content and qmp_savevm_start

[Wolfgang Bumiller]

Applied. Would be nice to have an option there, but it makes sense for
our use cases considering qemu shoulf always flush on close in these
cases.

On Mon, Aug 01, 2016 at 08:51:02AM +0200, Alexandre Derumier wrote:
> We don't send any flush here, so we need to open with cache=unsafe.
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  debian/patches/pve/0048-BDRV_O_CACHE_WB-was-removed.patch | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian/patches/pve/0048-BDRV_O_CACHE_WB-was-removed.patch b/debian/patches/pve/0048-BDRV_O_CACHE_WB-was-removed.patch
> index 9ec94f4..047c203 100644
> --- a/debian/patches/pve/0048-BDRV_O_CACHE_WB-was-removed.patch
> +++ b/debian/patches/pve/0048-BDRV_O_CACHE_WB-was-removed.patch
> @@ -32,7 +32,7 @@ index 4d73e66..2c41b17 100644
>       Error *local_err = NULL;
>   
>  -    int bdrv_oflags = BDRV_O_CACHE_WB | BDRV_O_RDWR;
> -+    int bdrv_oflags = BDRV_O_RDWR;
> ++    int bdrv_oflags = BDRV_O_RDWR | BDRV_O_NO_FLUSH;
>       int ret;
>   
>       if (snap_state.state != SAVE_STATE_DONE) {
> @@ -54,7 +54,7 @@ index c3db633..c1407d3 100644
>               char *devfn = NULL;
>               const char *format = NULL;
>  -            int flags = BDRV_O_RDWR|BDRV_O_CACHE_WB;
> -+            int flags = BDRV_O_RDWR;
> ++            int flags = BDRV_O_RDWR|BDRV_O_NO_FLUSH;
>               bool write_zero = true;
>   
>               if (readmap) {
> -- 
> 2.1.4
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>