[pve-devel] [PATCH] qemu-img convert : use default cache=unsafe instead writeback

[Wolfgang Bumiller]

Applied. qemu-img does a blk_unref() which at the end on the device
which should eventually end up in bdrv_close() doing a flush(). So this
should be safe in theory.

On Mon, Aug 01, 2016 at 08:51:00AM +0200, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 7778fb8..2414fd8 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5605,7 +5605,7 @@ sub qemu_img_convert {
>  	my $dst_path = PVE::Storage::path($storecfg, $dst_volid);
>  
>  	my $cmd = [];
> -	push @$cmd, '/usr/bin/qemu-img', 'convert', '-t', 'writeback', '-p', '-n';
> +	push @$cmd, '/usr/bin/qemu-img', 'convert', '-p', '-n';
>  	push @$cmd, '-s', $snapname if($snapname && $src_format eq "qcow2");
>  	push @$cmd, '-f', $src_format, '-O', $dst_format, $src_path;
>  	if ($is_zero_initialized) {
> -- 
> 2.1.4
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>