[pve-devel] Graphite.pm needs a correction

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 27 14:47:06 CEST 2016


Hi,

On 04/27/2016 02:34 PM, Alexey Kuzmin wrote:
> Hello Thomas,
>
> Is it really necessary for such a minor fix?
> I'm not going to claim any legal rights for one-character patch (:

One line or thousand are often indifferent in such cases, so for a
contribution this is really needed, I'm afraid, I also would welcome it
if no such obstacles would be needed, but not our rules. :)

That said, I'll give the issue a look and may resend a similar patch if
I verified it, so you save you some trouble.

To be honest I also hoped that we gain another contributor for our
project :P

Thanks for bringing the attention to this bug, and including a fix also!

cheers,
Thomas

>
>
> 2016-04-27 15:15 GMT+03:00 Thomas Lamprecht <t.lamprecht at proxmox.com>:
>
>> Hi,
>>
>> On 04/27/2016 01:55 PM, Alexey Kuzmin wrote:
>>> Hello,
>>>
>>> Carbon (particularly carbon-c-relay) expects one metric per line. Current
>>> PVE implementation breaks this rule. The following patch corrects this
>> bug.
>>> I also created a PR: https://github.com/proxmox/pve-manager/pull/6
>> First of all: Thank you for your contribution!
>>
>> This is no clone/fork run by any Proxmox official and we can not act on
>> the pull request there.
>> Further, you'll need to sign our open CLA to allow a contribution, if
>> you haven't done that yet,
>> that must be done to protect you and us legal wise, see
>> https://pve.proxmox.com/wiki/Developer_Documentation at the end of the
>> page.
>>
>> It would be really great if you could sign that and resend the fix in a
>> patch to the list.
>>
>> cheers & regards,
>> Thomas
>>
>>> Code:
>>>
>>> --- PVE/Status/Graphite.pm.orig  2016-04-26 20:03:02.961141497 +0000
>>> +++ PVE/Status/Graphite.pm  2016-04-26 20:03:14.541705841 +0000
>>> @@ -102,7 +102,7 @@
>>>   if ( ref $value eq 'HASH' ) {
>>>   write_graphite($carbon_socket, $value, $ctime, $path);
>>>   }else {
>>> -  $carbon_socket->send( "$path $value $ctime" );
>>> +  $carbon_socket->send( "$path $value $ctime\n" );
>>>   }
>>>   }
>>>   $path = $oldpath;
>>> _______________________________________________
>>> pve-devel mailing list
>>> pve-devel at pve.proxmox.com
>>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at pve.proxmox.com
>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>




More information about the pve-devel mailing list