[pve-devel] Graphite.pm needs a correction

Daniel Hunsaker danhunsaker at gmail.com
Wed Apr 27 14:42:08 CEST 2016


Yes, it's necessary for every patch, no matter the size or complexity.  It
protects Proxmox as well as contributors, not just from each other, but
also from other outside forces.  International law gets sticky sometimes,
and having these contributor agreements on file keeps things as smooth as
possible for everyone.

On Wed, Apr 27, 2016, 06:35 Alexey Kuzmin <al.m.kuzmin at gmail.com> wrote:

> Hello Thomas,
>
> Is it really necessary for such a minor fix?
> I'm not going to claim any legal rights for one-character patch (:
>
>
> 2016-04-27 15:15 GMT+03:00 Thomas Lamprecht <t.lamprecht at proxmox.com>:
>
> > Hi,
> >
> > On 04/27/2016 01:55 PM, Alexey Kuzmin wrote:
> > > Hello,
> > >
> > > Carbon (particularly carbon-c-relay) expects one metric per line.
> Current
> > > PVE implementation breaks this rule. The following patch corrects this
> > bug.
> > > I also created a PR: https://github.com/proxmox/pve-manager/pull/6
> >
> > First of all: Thank you for your contribution!
> >
> > This is no clone/fork run by any Proxmox official and we can not act on
> > the pull request there.
> > Further, you'll need to sign our open CLA to allow a contribution, if
> > you haven't done that yet,
> > that must be done to protect you and us legal wise, see
> > https://pve.proxmox.com/wiki/Developer_Documentation at the end of the
> > page.
> >
> > It would be really great if you could sign that and resend the fix in a
> > patch to the list.
> >
> > cheers & regards,
> > Thomas
> >
> > >
> > > Code:
> > >
> > > --- PVE/Status/Graphite.pm.orig  2016-04-26 20:03:02.961141497 +0000
> > > +++ PVE/Status/Graphite.pm  2016-04-26 20:03:14.541705841 +0000
> > > @@ -102,7 +102,7 @@
> > >   if ( ref $value eq 'HASH' ) {
> > >   write_graphite($carbon_socket, $value, $ctime, $path);
> > >   }else {
> > > -  $carbon_socket->send( "$path $value $ctime" );
> > > +  $carbon_socket->send( "$path $value $ctime\n" );
> > >   }
> > >   }
> > >   $path = $oldpath;
> > > _______________________________________________
> > > pve-devel mailing list
> > > pve-devel at pve.proxmox.com
> > > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> > >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>


More information about the pve-devel mailing list