[pve-devel] [PATCH common 1/2] Fix indexed parameter conversion in API dump

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Apr 19 11:47:54 CEST 2016


this would previously skip (i.e., ignore) properties that
matched '^([a-z]+)(\d+)$' even if they were not part of an
indexed properties series (which always start with 0).

This fixes previously missing API dump occurrences of:
-smbios1
-comments6
-netmask6
-gateway6
-address6
-dns1
-dns2
-dns3
-server1
-server2
---
 src/PVE/RESTHandler.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
index 6799fde..ca3f99b 100644
--- a/src/PVE/RESTHandler.pm
+++ b/src/PVE/RESTHandler.pm
@@ -36,8 +36,8 @@ sub api_clone_schema {
 	    if ($p =~ m/^([a-z]+)(\d+)$/) {
 		if ($2 == 0) {
 		    $p = "$1\[n\]";
-		} else {
-		    next;
+		} elsif (defined($d->{$1.'0'})) {
+		    next; # only handle once for -xx0, but only if -xx0 exists
 		}
 	    }
 	    $res->{$k}->{$p} = ref($pd) ? clone($pd) : $pd;
-- 
2.1.4




More information about the pve-devel mailing list