[pve-devel] Add support for external graphite metric server

[Alexandre DERUMIER]

>>Does that work? 

yes, thanks. 

I'll fix that in my patch for plugin.pm too

----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 22 Juin 2015 17:25:05
Objet: Re: [pve-devel] Add support for external graphite metric server

> On June 22, 2015 at 4:53 PM Alexandre DERUMIER <aderumier at odiso.com> wrote: 
> 
> 
> Hi Dietmar, 
> 
> I have a bug in current plugin framework 
> 
> inside Graphite.pm 
> 
> for example 
> sub update_node_status { 
> my ($plugin_config, $node, $data, $ctime) = @_; 
> 
> } 
> 
> The $plugin_config var content = 'PVE::Status::Graphite' ??? 
> 
> 
> in pvestatd, this is correct 
> 
> my $plugin_config = $status_cfg->{ids}->{$id}; 
> 
> I have the hashref with plugin options 
> 
> 
> Any idea ? 
> 

Sorry, the first element is the $class. So please correct 
the function signature to: 

sub update_node_status { 
my ($class, $plugin_config, $node, $data, $ctime) = @_; 

Does that work?