[pve-devel] [RFC PATCH 0/3] [manager] network interfaces internal API change

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Jun 22 16:07:04 CEST 2015


This is the pve-manager part of a set of patches for
  [ ] pve-common
  [*] pve-manager

These patches upgrade code dealing with /etc/network/interfaces to the
new interface, and add API support for ipv6 addresses.

I'm currently using perl's Net::IP::ip_iptypev6 to extract the IP's
type in order to validate whether it's a valid IP to assign to an
interface. I'm not sure whether this covers all usecases correctly, or
whether we want to do this at all?
At least it prevents the use of multicast and reserved addresses. It
permits the use of global/local/unique unicast addresses and addresses
which are not part of any known reserved range.
Special ranges are usually handled by external tools anyway (eg. with
miredo/teredo addresses are assigned by daemons and not written to
configuration files. However I'm not sure about whether this is also
true for other tunneling services.)
Regardless, special cases can still be configured as a custom
configuration in a separate file included via "source".

Patch 3 adds ipv6 configuration to the GUI. This is a temporary
solution!
For containers ipv4 and ipv6 addresses are shown below each other in
the same column. We probably want the same behavior here?
For now I just wanted to get it working and all the rest of the
patchset reviewed and commented on before hacking through the UI code.
(and adding new columns was as easy as copy&pasting existing code)
(Ideally only the final UI change makes into the repo to not
unnecessarily increase Emmanuel's workload with piles of patches ;-) )

Wolfgang Bumiller (3):
  PVE::API2::Ceph: network_interfaces update + ipv6
  PVE::API2::Network: network_interfaces update + ipv6
  www/network: ipv6 related columns and edit fields

 PVE/API2/Ceph.pm                |  14 ++--
 PVE/API2/Network.pm             | 142 ++++++++++++++++++++++++++++++++--------
 www/manager/Toolkit.js          |   6 ++
 www/manager/Utils.js            |   1 +
 www/manager/node/NetworkEdit.js |  39 +++++++++++
 www/manager/node/NetworkView.js |  20 +++++-
 6 files changed, 188 insertions(+), 34 deletions(-)

-- 
2.1.4




More information about the pve-devel mailing list