[pve-devel] [PATCH] lxc: add hotplug memory && cpus cgroups value

[Alexandre DERUMIER]

don't have remove the die yet, as all others options are not hotpluggable yet. 
(do we need to implement pending for network ?) 


but it's working if you remove the die


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Samedi 20 Juin 2015 16:40:18
Objet: Re: [pve-devel] [PATCH] lxc: add hotplug memory && cpus cgroups value

> On June 20, 2015 at 2:13 PM Alexandre Derumier <aderumier at odiso.com> wrote: 
> 
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com> 
> --- 
> src/PVE/LXC.pm | 18 +++++++++++++++++- 
> 1 file changed, 17 insertions(+), 1 deletion(-) 
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm 
> index 068b46f..733fe4f 100644 
> --- a/src/PVE/LXC.pm 
> +++ b/src/PVE/LXC.pm 
> @@ -966,13 +966,14 @@ sub update_lxc_config { 
> 
> # fixme: hotplug 
> die "unable to modify config while container is running\n" if $running; 

are you sure your patch works? Maybe you wanted to remove 
above 'die' for memory,swap,cpuunits and cpulimit?