[pve-devel] [PATCH] qemuserver : vm_status : add extended stats (disks, nics, memory).

[Dietmar Maurer]

> > + $d->{memory} = $info; 
> 
> >>Why? We already copied all data? 
> currently we send
> 
> max_mem
> actual
> free_mem
> mem = total_mem - free_mem
> 
> ballon info return more counters
> 
> actual
> max_mem
> total_mem (great to have it without doing reverse mem+free_mem)
> free_mem
> mem_swapped_in
> mem_swapped_out
> major_page_faults
> minor_page_faults

But you use a very generic name 'memory'. Maybe we should use

$d->{qemu_balloon_info} = $info;

instead? 

> >>I am quite unsure if we should directly pass qemu data. For example, I would
> >>
> >>like 
> >>to have qemu-server device names (instead of blockstat->{device}).
> 
> That's a good idea. Like this if we change from virtio to scsi, we keep the
> same stats.
> Have the storageid too can be usefull to do aggreated stats for a specific
> storage
> 
> {vmid}->{disks}->{storageid}->{volumename}

by maybe call it: 

{vmid}->{qemu_blockstat}->{storageid}->{volumename}


> >>Also, this 
> >>only works 
> >>with qemu, so what about LXC? 
> 
> I don't have checked how you get counters for lxc. 
> We also have counters in cgroups.

Yes, but different ones.