[pve-devel] [PATCH] memory hotplug patch v10

[Alexandre DERUMIER]

>>Please can you factor out the code to compute dimm sizes into a separate method? 
>>I don't want that code duplicated 2 times. 

Yes, no problem, I thinked to do it this week.

also ballooning don't work correctly currently with dimm memory,
because total memory compute don't take dimm values.

A patch has been sent to qemu-mailing, but not yet applied
http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg02050.html

I don't known if we want to apply it on pve-qemu-kvm, or wait for qemu 2.3.
(I think both unplug and balloon fix will be ready for qemu 2.3)





----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>, "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 28 Janvier 2015 07:09:59
Objet: Re: [pve-devel] [PATCH] memory hotplug patch v10

applied, thanks! 

> + if ($hotplug_features->{memory}) { 
> + my $dimm_id = 0; 
> + my $dimm_size = 512; 
> + my $current_size = $static_memory; 
> + for (my $j = 0; $j < 8; $j++) { 
> + for (my $i = 0; $i < 32; $i++) { 
> + my $name = "dimm${dimm_id}"; 
> + $dimm_id++; 

Please can you factor out the code to compute dimm sizes into a separate method? 
I don't want that code duplicated 2 times.