[pve-devel] [PATCH] memory hotplug patch v10
Dietmar Maurer
dietmar at proxmox.com
Wed Jan 28 07:09:59 CET 2015
applied, thanks!
> + if ($hotplug_features->{memory}) {
> + my $dimm_id = 0;
> + my $dimm_size = 512;
> + my $current_size = $static_memory;
> + for (my $j = 0; $j < 8; $j++) {
> + for (my $i = 0; $i < 32; $i++) {
> + my $name = "dimm${dimm_id}";
> + $dimm_id++;
Please can you factor out the code to compute dimm sizes into a separate method?
I don't want that code duplicated 2 times.
More information about the pve-devel
mailing list