[pve-devel] [PATCH] tap_plug : add support for vlan aware linux bridge

[Andrew Thrift]

Hi Alexandre,

We also use QinQ and have submitted patches for the previous network
implementation that made use of a "bridge in bridge" design to achieve the
QinQ functionality.

The new vlan aware bridge implementation will be a lot cleaner.

When your patches are ready we will test them and provide feedback.


Thanks,



Andrew

On Tue, Jul 28, 2015 at 2:09 AM, Alexandre DERUMIER <aderumier at odiso.com>
wrote:

> does somebody have tested my vlan bridges patches ?  (note that that need
> iproute2 from debian sid, for vlan ranges)
>
> It's working really fine here, I'm looking to add a patch for Q-in-Q
> bridge too. (I think Stefan Priebe use them)
>
>
>
>
>
> ----- Mail original -----
> De: "aderumier" <aderumier at odiso.com>
> À: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
> Cc: "pve-devel" <pve-devel at pve.proxmox.com>
> Envoyé: Vendredi 24 Juillet 2015 18:49:18
> Objet: Re: [pve-devel] [PATCH] tap_plug : add support for vlan aware linux
> bridge
>
> >>Why is `bridge_add_interface` now restricted to the firewall-else
> >>branch?
>
> I manage it like openvswitch,
>
> vlan tagging is always done on the main bridge, not firewall bridge.
>
>
> > + if ($firewall) {
> > + &$create_firewall_bridge_linux($iface, $bridge, $tag);
>
> create_firewall_bridge_linux($iface, $bridge, $tag)
> have
>
> - &$bridge_add_interface($bridge, $vethfwpeer);
> + &$bridge_add_interface($bridge, $vethfwpeer, $tag); #tag on the main
> bridge
> - return $fwbr;
> + &$bridge_add_interface($fwbr, $iface); # add vm tap interface on
> fwbridge without vlan tag
>
>
>
>
>
>
>
>
>
> ----- Mail original -----
> De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
> À: "aderumier" <aderumier at odiso.com>
> Cc: "pve-devel" <pve-devel at pve.proxmox.com>
> Envoyé: Vendredi 24 Juillet 2015 15:20:06
> Objet: Re: [pve-devel] [PATCH] tap_plug : add support for vlan aware linux
> bridge
>
> On Fri, Jul 24, 2015 at 01:52:59PM +0200, Alexandre Derumier wrote:
> > - $newbridge = &$create_firewall_bridge_linux($iface, $newbridge) if
> $firewall;
> > + if (!$vlan_aware) {
> > + my $newbridge = activate_bridge_vlan($bridge, $tag);
> > + copy_bridge_config($bridge, $newbridge) if $bridge ne $newbridge;
> > + $tag = undef;
> > + }
> > +
> > + if ($firewall) {
> > + &$create_firewall_bridge_linux($iface, $bridge, $tag);
> > + } else {
> > + &$bridge_add_interface($bridge, $iface, $tag);
> > + }
> >
> > - &$bridge_add_interface($newbridge, $iface);
>
>
> Why is `bridge_add_interface` now restricted to the firewall-else
> branch?
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20150804/c5e32152/attachment.htm>