[pve-devel] [PATCH] tap_plug : add support for vlan aware linux bridge

[Alexandre DERUMIER]

>>Yes but if /sys/class/net/$IFACE/bridge/vlan_filtering is off then all
>>interfaces stay untagged silently, while the vmbrXvY bridges are still
>>generated but not used.

Ah ok, seem to be a bug.

I think this is because of

if (!$vlan_aware) {
       my $newbridge = activate_bridge_vlan($bridge, $tag);
        ...

....
 &$bridge_add_interface($bridge, $iface, $tag);



because of $newbridge != $bridge.



I'll fix this and send a patch 

----- Mail original -----
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 3 Août 2015 13:04:05
Objet: Re: [pve-devel] [PATCH] tap_plug : add support for vlan aware linux bridge

On Mon, Aug 03, 2015 at 12:02:10PM +0200, Alexandre DERUMIER wrote: 
> >>But you also now only add tap devices to vmbrX instead of vmbrXvY, 
> >>which is wrong, the vmbrXvY bridges are now virtually unused. 
> 
> Yes, this is expected. 
> we don't need vmbrXvY anymore, because we tag vlan on vmbrX ports directly. 

Yes but if /sys/class/net/$IFACE/bridge/vlan_filtering is off then all 
interfaces stay untagged silently, while the vmbrXvY bridges are still 
generated but not used. 

> try, 
> 
> #brigge -c vlan 
> 
> you should like vlan tag list for each tap interface. 

Yes, but only with `bridge_vlan_aware yes`, otherwise the setup will 
fail silently.