> So, with this code, we always call qemu-img snasphot for qcow2, which is wrong > if the vm is running. > (for rbd,zfs,.. no problem). > > I think that's why we passed the running flag to pve-storage. Ah, yes - the logic is wrong, but fixable.