[pve-devel] [PATCH 2/2] forbid hot-unplug of virtioscsi + iothread drive

[Alexandre Derumier]

qemu (<=2.3) currently segfault on drive_del

Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
---
 PVE/QemuServer.pm |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6b2bab8..9fe1684 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3379,6 +3379,10 @@ sub vm_deviceunplug {
 
     } elsif ($deviceid =~ m/^(scsi)(\d+)$/) {
 
+	#qemu 2.3 segfault on drive_del with virtioscsi + iothread
+	my $device = parse_drive($deviceid, $conf->{$deviceid});
+	die "virtioscsi with iothread is not hot-unplugglable currently" if $device->{iothread};
+
         qemu_devicedel($vmid, $deviceid);
         qemu_drivedel($vmid, $deviceid);
 	qemu_deletescsihw($conf, $vmid, $deviceid);
-- 
1.7.10.4