[pve-devel] [PATCH] Add CT suspend/resume to PVE API

Daniel Hunsaker danhunsaker at gmail.com
Fri Oct 3 09:55:32 CEST 2014


I noticed the whitespace changes after I sent this one, and resent it
without them shortly after.  Sent a reply that I was going to resend, but
it seems not all my emails get through to the list?

How would you recommend I split the changes?  They're all related directly
to providing suspend/resume support.
On Oct 3, 2014 12:25 AM, "Dietmar Maurer" <dietmar at proxmox.com> wrote:

> First, thanks for the patch. But please can you split the patch into
> smaller ones?
>
> > Signed-off-by: Dan Hunsaker <danhunsaker at gmail.com>
> > ---
> >  PVE/API2/OpenVZ.pm            | 308
> +++++++++++++++++++++++++++---------------
> >  PVE/OpenVZ.pm                 |  92 ++++++++-----
> >  bin/pvectl                    |  16 ++-
> >  www/manager/Utils.js          |  80 +++++------
> >  www/manager/openvz/CmdMenu.js |  28 +++-
> >  www/manager/qemu/CmdMenu.js   |  26 +++-
> >  www/mobile/OpenVzSummary.js   |  30 ++--
> >  www/mobile/QemuSummary.js     |  34 +++--
> >  8 files changed, 401 insertions(+), 213 deletions(-)
> >
> > diff --git a/PVE/API2/OpenVZ.pm b/PVE/API2/OpenVZ.pm
> > index 184ebdf..5d8c0c6 100644
> > --- a/PVE/API2/OpenVZ.pm
> > +++ b/PVE/API2/OpenVZ.pm
> > @@ -71,7 +71,7 @@ my $get_container_storage = sub {
> >
> >  my $check_ct_modify_config_perm = sub {
> >      my ($rpcenv, $authuser, $vmid, $pool, $key_list) = @_;
> > -
> > +
>
> And there are tons of white-space changes. Please remove them first.
>
> - Dietmar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20141003/fc473486/attachment.htm>


More information about the pve-devel mailing list