[pve-devel] [PATCH] Add CT suspend/resume to PVE API

Dietmar Maurer dietmar at proxmox.com
Fri Oct 3 08:25:06 CEST 2014


First, thanks for the patch. But please can you split the patch into smaller ones?

> Signed-off-by: Dan Hunsaker <danhunsaker at gmail.com>
> ---
>  PVE/API2/OpenVZ.pm            | 308 +++++++++++++++++++++++++++---------------
>  PVE/OpenVZ.pm                 |  92 ++++++++-----
>  bin/pvectl                    |  16 ++-
>  www/manager/Utils.js          |  80 +++++------
>  www/manager/openvz/CmdMenu.js |  28 +++-
>  www/manager/qemu/CmdMenu.js   |  26 +++-
>  www/mobile/OpenVzSummary.js   |  30 ++--
>  www/mobile/QemuSummary.js     |  34 +++--
>  8 files changed, 401 insertions(+), 213 deletions(-)
> 
> diff --git a/PVE/API2/OpenVZ.pm b/PVE/API2/OpenVZ.pm
> index 184ebdf..5d8c0c6 100644
> --- a/PVE/API2/OpenVZ.pm
> +++ b/PVE/API2/OpenVZ.pm
> @@ -71,7 +71,7 @@ my $get_container_storage = sub {
> 
>  my $check_ct_modify_config_perm = sub {
>      my ($rpcenv, $authuser, $vmid, $pool, $key_list) = @_;
> -
> +

And there are tons of white-space changes. Please remove them first.

- Dietmar




More information about the pve-devel mailing list