[pve-devel] bug ? vmstate state snapshot file not closed on cancel

Dietmar Maurer dietmar at proxmox.com
Thu Nov 20 07:21:37 CET 2014


> >>This is now done by a ref counting schema:
> >>
> >>bdrv_unref(snap_state.bs);
> 
> Yes, I see it in save_snapshot_cleanup().
> 
> which is used in save_snapshot_error() and save_snapshot_completed().
> 
> 
> But it seem that when you manually abort the task, it's never called.
> 
> we call qmp savevm-end if we catch the error, but the save_snapshot_cleanup in
> not in savevm-end.

Would be great if you can track this down.



More information about the pve-devel mailing list