[pve-devel] bug ? vmstate state snapshot file not closed on cancel

[Alexandre DERUMIER]

>>This is now done by a ref counting schema:
>>
>>bdrv_unref(snap_state.bs);

Yes, I see it in save_snapshot_cleanup().

which is used in save_snapshot_error() and save_snapshot_completed().


But it seem that when you manually abort the task, it's never called.

we call qmp savevm-end if we catch the error,
but the save_snapshot_cleanup in not in savevm-end.




>>Do you use iothreads? If so, also test without. 
this is without iothread.
	

----- Mail original -----

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mercredi 19 Novembre 2014 19:44:39 
Objet: RE: [pve-devel] bug ? vmstate state snapshot file not closed on cancel 

> I have check inside internal-snapshot-async.patch, I don't see any bdrv_close 
> anywhere 

This is now done by a ref counting schema: 

bdrv_unref(snap_state.bs); 

Do you use iothreads? If so, also test without.