[pve-devel] [PATCH 1/2] add firewall option to qemu network interface

[Alexandre DERUMIER]

>> Why do you pass all those parameters to tap_unplug? 

we can remove them, this is old code.

>>And why do we ignore errors here? 

we can remove eval too, I think before we didn't check in tap_unplug where the tap was really plugged.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Jeudi 8 Mai 2014 08:58:58 
Objet: RE: [pve-devel] [PATCH 1/2] add firewall option to qemu network interface 

> - if(($newnet->{bridge} ne $oldnet->{bridge}) || ($newnet- 
> >{tag} ne $oldnet->{tag})){ 
> - eval{PVE::Network::tap_unplug($iface, $oldnet->{bridge}, 
> $oldnet->{tag});}; 
> - PVE::Network::tap_plug($iface, $newnet->{bridge}, 
> $newnet->{tag}); 
> + if(($newnet->{bridge} ne $oldnet->{bridge}) || ($newnet- 
> >{tag} ne $oldnet->{tag}) || ($newnet->{firewall} ne $oldnet->{firewall})){ 
> + eval{PVE::Network::tap_unplug($iface, $oldnet->{bridge}, 
> $oldnet->{tag}, $oldnet->{firewall});}; 

Why do you pass all those parameters to tap_unplug? 

And why do we ignore errors here?