[pve-devel] [PATCH 1/2] add firewall option to qemu network interface

[Dietmar Maurer]

> -		if(($newnet->{bridge} ne $oldnet->{bridge}) || ($newnet-
> >{tag} ne $oldnet->{tag})){
> -		    eval{PVE::Network::tap_unplug($iface, $oldnet->{bridge},
> $oldnet->{tag});};
> -		    PVE::Network::tap_plug($iface, $newnet->{bridge},
> $newnet->{tag});
> +		if(($newnet->{bridge} ne $oldnet->{bridge}) || ($newnet-
> >{tag} ne $oldnet->{tag}) || ($newnet->{firewall} ne $oldnet->{firewall})){
> +		    eval{PVE::Network::tap_unplug($iface, $oldnet->{bridge},
> $oldnet->{tag}, $oldnet->{firewall});};

Why do you pass all those parameters to tap_unplug?

And why do we ignore errors here?