[pve-devel] Storage plugins : is "properties" unique ?

[Alexandre DERUMIER]

yes, the properties must be defined in 1 plugin only, and are shared across all plugins. 

If you need a property path, and if it's the same format than in other plugin, no need to redefined it.

If your path property is in another format, you need to choose another name for the property.




----- Mail original ----- 

De: "Florent Bautista" <florent at coppint.com> 
À: pve-devel at pve.proxmox.com 
Envoyé: Lundi 28 Octobre 2013 12:51:44 
Objet: [pve-devel] Storage plugins : is "properties" unique ? 

Hi all, 

I'm trying to create a storage plugin for Proxmox, and I have a little 
problem. 

Are "properties" values of a plugin needs to be unique for all the 
system ? And why ? 

Example : when I set a property called "path" in my plugin, pveproxy 
failed to start with those errors : 

Restarting PVE API Proxy Server: pveproxyduplicate property at 
/usr/share/perl5/PVE/SectionConfig.pm line 123, <DATA> line 558. 
Compilation failed in require at /usr/share/perl5/PVE/API2/Cluster.pm 
line 13, <DATA> line 558. 
BEGIN failed--compilation aborted at 
/usr/share/perl5/PVE/API2/Cluster.pm line 13, <DATA> line 558. 
Compilation failed in require at /usr/share/perl5/PVE/API2.pm line 12, 
<DATA> line 558. 
BEGIN failed--compilation aborted at /usr/share/perl5/PVE/API2.pm line 
12, <DATA> line 558. 
Compilation failed in require at /usr/share/perl5/PVE/REST.pm line 9, 
<DATA> line 558. 
BEGIN failed--compilation aborted at /usr/share/perl5/PVE/REST.pm line 
9, <DATA> line 558. 
Compilation failed in require at /usr/share/perl5/PVE/HTTPServer.pm line 
25, <DATA> line 558. 
BEGIN failed--compilation aborted at /usr/share/perl5/PVE/HTTPServer.pm 
line 25, <DATA> line 558. 
Compilation failed in require at /usr/share/perl5/PVE/APIDaemon.pm line 
11, <DATA> line 558. 
BEGIN failed--compilation aborted at /usr/share/perl5/PVE/APIDaemon.pm 
line 11, <DATA> line 558. 
Compilation failed in require at /usr/bin/pveproxy line 15, <DATA> line 558. 
BEGIN failed--compilation aborted at /usr/bin/pveproxy line 15, <DATA> 
line 558. 
(warning). 


I looked line 123 of SectionConfig.pm and it seems that properties are 
not PER plugin but over all the system. 
And "path" property is already used by DirPlugin. 

Is it normal ? What represents "properties" exactly ? 

Thank you for you help :) 
_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel