[pve-devel] [PATCH] convert usb2 config from pve-usb.cfg to commandline

[Alexandre DERUMIER]

>>What is the reasoning behind that? We already have a long and complicated command line, 
>>and I am not keen to make it even longer. 

It was just to avoid an external config file (also libvirt do it like this)

>>AFAIK the command line length also has a hard limit (4096 bytes ?), so we should 
>>try to keep that as short as possible. 

Oh, I don't known that. 
I can rework my patches to reuse old config file.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Vendredi 22 Février 2013 08:39:41 
Objet: RE: [pve-devel] [PATCH] convert usb2 config from pve-usb.cfg to commandline 

> - push @$devices, '-readconfig', '/usr/share/qemu-server/pve-usb.cfg'; 
> + $pciaddr = print_pci_addr("ehci", $bridges); 
> + push @$devices, '-device', "ich9-usb- 
> ehci1,id=ehci,multifunction=on$pciaddr.0x7"; 
> + push @$devices, '-device', "ich9-usb- 
> uhci1,id=uhci1,masterbus=ehci.0,firstport=0,multifunction=on$pciaddr.0x0"; 
> + push @$devices, '-device', "ich9-usb- 
> uhci2,id=uchi2,masterbus=ehci.0,firstport=2,multifunction=on$pciaddr.0x1"; 
> + push @$devices, '-device', 
> + "ich9-usb-uhci3,id=uchi3,masterbus=ehci.0,firstport=4,multifunction=on 
> + $pciaddr.0x2"; 

What is the reasoning behind that? We already have a long and complicated command line, 
and I am not keen to make it even longer. 

AFAIK the command line length also has a hard limit (4096 bytes ?), so we should 
try to keep that as short as possible.