[pve-devel] [PATCH] convert usb2 config from pve-usb.cfg to commandline

Dietmar Maurer dietmar at proxmox.com
Fri Feb 22 08:39:41 CET 2013


> -    push @$devices, '-readconfig', '/usr/share/qemu-server/pve-usb.cfg';
> +    $pciaddr = print_pci_addr("ehci", $bridges);
> +    push @$devices, '-device', "ich9-usb-
> ehci1,id=ehci,multifunction=on$pciaddr.0x7";
> +    push @$devices, '-device', "ich9-usb-
> uhci1,id=uhci1,masterbus=ehci.0,firstport=0,multifunction=on$pciaddr.0x0";
> +    push @$devices, '-device', "ich9-usb-
> uhci2,id=uchi2,masterbus=ehci.0,firstport=2,multifunction=on$pciaddr.0x1";
> +    push @$devices, '-device',
> + "ich9-usb-uhci3,id=uchi3,masterbus=ehci.0,firstport=4,multifunction=on
> + $pciaddr.0x2";

What is the reasoning behind that? We already have a long and complicated command line,
and I am not keen to make it even longer.

AFAIK the command line length also has a hard limit (4096 bytes ?), so we should 
try to keep that as short as possible. 




More information about the pve-devel mailing list