[pve-devel] activate hotplug by default ?

[Martin Maurer]

> -----Original Message-----
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> Sent: Dienstag, 19. Februar 2013 18:53
> To: Dietmar Maurer
> Cc: pve-devel at pve.proxmox.com; Martin Maurer
> Subject: Re: [pve-devel] activate hotplug by default ?
> 
> >>hot-unplug looks dangerous for me anyways - maybe we should only allow
> >>hot-add for disks?
> Yes, no problem for me.

I also vote for this. Hot-unplug is too dangerous as default setup.
 
> Sure It's dangerous if your disks are mounted. (Maybe with guest-agent in
> the futur we could check if the disks are mounted or not).
> It could be great to keep an option to activate disk hot-unplug for advanced
> users.

maybe via a global datacenter configuration (planning).

> 
> About the windows "bug":
> 
> I found a way, with calling drive_del after device_del.
> windows acpi don't unplug the disk until it's mounted, so it's safe, and we
> keep access to disk
> 
> But on Linux that doesn't work, the device removal hang.
> (Normal linux behaviour was to remove correctly the device, but of course,
> mount point is hanging)
> 
> 
> I don't like too much this kind of trick which depend of the guest os.
> (Anyway libvirt implement drive_del before device_del, to be sure that datas
> are correctly flushed)
> 
> 
> So I think guest-agent is the only 100% safe way for removal.

That sounds better, yes.

Martin