[pve-devel] [PATCH 2/2] parse_drive : return correct format

Dietmar Maurer dietmar at proxmox.com
Tue Apr 30 09:25:09 CEST 2013

> >>Btw, your clone patches have the feature to set the format for each
> >>drive. Do we really need that?
> Yes, because we create the volume before using qemu-img convert.
> But we also need to specify it to qemu-img convert, as auto-detection of the
> target volume format don't work.
> (I have tried, creating a .qcow2 file, qemu-img convert override it with raw
> format is no format specified)

Sorry, I do not really understand that. In the other mail you wrote that it would
be enough to specify one single -format parameter?

> >>Maybe it is enough to have an extra API for that (migrate_disk)?
> In my patches, I have a qm move api for storage migration, which reuse a
> common clone_disk{}.(using qemu-img convert offline or drive-mirror online)

Sure, I already saw that. I just split your patches into smaller steps. I want to test
and understand each single line of that code. Hope that is OK for you?

I will re-create the clone_disk() later if needed.

More information about the pve-devel mailing list