[pve-devel] [PATCH 2/2] parse_drive : return correct format

Alexandre DERUMIER aderumier at odiso.com
Tue Apr 30 08:06:18 CEST 2013


>>Btw, your clone patches have the feature to set the format for each drive. 
>>Do we really need that? 

Yes, because we create the volume before using qemu-img convert.

But we also need to specify it to qemu-img convert, as auto-detection of the target volume format don't work.
(I have tried, creating a .qcow2 file, qemu-img convert override it with raw format is no format specified)


>>Maybe it is enough to have an extra API for that (migrate_disk)? 
In my patches, I have a qm move api for storage migration, which reuse a common clone_disk{}.(using qemu-img convert offline or drive-mirror online)



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Mardi 30 Avril 2013 06:58:39 
Objet: RE: [pve-devel] [PATCH 2/2] parse_drive : return correct format 

applied. 

Btw, your clone patches have the feature to set the format for each drive. 
Do we really need that? 

I mean, we want to be able to copy a single disk from one location to another, 
and change the disk format on that action. 

But is this related to VM copy. 

Maybe it is enough to have an extra API for that (migrate_disk)? 

> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier 
> Sent: Dienstag, 30. April 2013 06:18 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH 2/2] parse_drive : return correct format 
> 
> Currently format is always empty, we need to parse file extension 


More information about the pve-devel mailing list