[pve-devel] about nexentaplugin eval

[Alexandre DERUMIER]

>>How can I reproduce that bug? For me it work without eval. 
Last step sometime can fail with a (lot) lot of volumes. (api timeout,taking too much time to find a free lunid)

>>The old code was simply buggy (you can create volume multiple time without error for example). 
you can't create a volume twice (nexenta side). Last step don't have eval, so It's die if you try to create a disk twice.



About sleep, Indeed, I dont' like this too,I will retest without them. 



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Lundi 17 Septembre 2012 11:30:54 
Objet: RE: [pve-devel] about nexentaplugin eval 

> eval are here, if something goes wrong at last step, 
> nexenta_add_lun_mapping_entry, 
> 
> and ifyou retry to create disk again, 
> 
> if no eval, it will hang at step1. 

How can I reproduce that bug? For me it work without eval. 

The old code was simply buggy (you can create volume multiple time without error for example). 
I just remove all those hack, because they do not lock reasonable to me. 

I am testing now, and I will re-add those hack if really necessary. 

But 'sleep' is a very bad solution IMHO.