[pve-devel] [PATCH] volume_snapshot : add testfeature option param

[Alexandre DERUMIER]

Hi, I just want to not have harcoded values in qemu-server, but use pve-storage plugins.

It's more easy if you want to developp a new storage module, without need to maintain pve-storage and qemu-server.

Maybe do you have a better idea to implement this ?

----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre Derumier" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Lundi 1 Octobre 2012 06:32:44 
Objet: RE: [pve-devel] [PATCH] volume_snapshot : add testfeature option param 

This hide knowledge inside a function. Instead. I would prefer to have 
a declarative way specify such features. What exactly is the advantage of 
this patch compared with current implementation? 

> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier 
> Sent: Freitag, 28. September 2012 16:22 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH] volume_snapshot : add testfeature option 
> param 
> 
> return 1 for storage which support snapshot before doing the snapshot