[pve-devel] [PATCH] volume_snapshot : add testfeature option param

Dietmar Maurer dietmar at proxmox.com
Mon Oct 1 06:35:32 CEST 2012


Note: You distribute a single 'if' statement over 5 files - why do you think that is better?

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Freitag, 28. September 2012 16:22
> To: pve-devel at pve.proxmox.com
> Subject: [pve-devel] [PATCH] volume_snapshot : add testfeature option
> param
> 
> return 1 for storage which support snapshot before doing the snapshot
> 
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/Storage.pm                |    4 ++--
>  PVE/Storage/NexentaPlugin.pm  |    4 +++-
>  PVE/Storage/Plugin.pm         |    6 +++---
>  PVE/Storage/RBDPlugin.pm      |    4 ++--
>  PVE/Storage/SheepdogPlugin.pm |    6 +++---
>  5 files changed, 13 insertions(+), 11 deletions(-)




More information about the pve-devel mailing list