[pve-devel] [PATCH] Adds configuration of disk io op/s and byte/s limits

[Dietmar Maurer]

OK, changed that to 1024*1024

> -----Original Message-----
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel-
> bounces at pve.proxmox.com] On Behalf Of Timo Grodzinski
> Sent: Samstag, 16. Juni 2012 16:48
> To: PVE Devel
> Subject: Re: [pve-devel] [PATCH] Adds configuration of disk io op/s and
> byte/s limits
> 
> I would also assume powers of 2 when I read MB/s whereas MiB/s would be
> more accurate description.
> 
> Timo
> 
> On Sat, 16 Jun 2012 14:56:36 +0200, Dietmar Maurer
> <dietmar at proxmox.com>
> wrote:
> 
> > Why? GUI display MB/s (not MiB/s)
> >
> > Note: good to have you back ;-)
> >
> >> -----Original Message-----
> >> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> >> Sent: Samstag, 16. Juni 2012 09:54
> >> To: Dietmar Maurer
> >> Cc: Stefan Priebe - Profihost AG; pve-devel at pve.proxmox.com
> >> Subject: Re: [pve-devel] [PATCH] Adds configuration of disk io op/s
> >> and byte/s limits
> >>
> >> Hi, I'm reading the code, and I see
> >>
> >>   values.bps_rd = drive.bps_rd / 1000000;
> >> +       values.bps_wr = drive.bps_wr / 1000000;
> >>
> >>
> >>
> >> 1048576 should be used instead of 1000000.
> >>
> >>
> >> ----- Mail original -----
> >>
> >> De: "Dietmar Maurer" <dietmar at proxmox.com>
> >> À: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>, pve-
> >> devel at pve.proxmox.com
> >> Envoyé: Jeudi 14 Juin 2012 09:49:05
> >> Objet: Re: [pve-devel] [PATCH] Adds configuration of disk io op/s and
> >> byte/s limits
> >>
> >> > > Units is still bytes/s, which is IMHO not ideal. Should we change
> >> > > that to
> >> > KB/s?
> >> >
> >> > I would suggest MB/s. I think nobody wants to set limits in bytes
> >> > or even kbytes range.
> >>
> >> Ok, changed to MB/s
> >>
> >> - Dietmar
> >>
> >> _______________________________________________
> >> pve-devel mailing list
> >> pve-devel at pve.proxmox.com
> >> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >>
> >>
> >>
> >> --
> >>
> >> --
> >>
> >>
> >>
> >>
> >> 	Alexandre D erumier
> >> Ingénieur Système
> >> Fixe : 03 20 68 88 90
> >> Fax : 03 20 68 90 81
> >> 45 Bvd du Général Leclerc 59100 Roubaix - France
> >> 12 rue Marivaux 75002 Paris - France
> >>
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> --
> Mit freundlichen Grüßen
>    Timmo Grodzinski
> Ihr Profihost Team
> 
> -------------------------------
> Profihost AG
> Am Mittelfelde 29
> 30519 Hannover
> Deutschland
> 
> Tel.: +49 (511) 5151 8181     | Fax.: +49 (511) 5151 8282
> URL: http://www.profihost.com | E-Mail: info at profihost.com
> 
> Sitz der Gesellschaft: Hannover, USt-IdNr. DE813460827
> Registergericht: Amtsgericht Hannover, Register-Nr.: HRB 202350
> Vorstand: Cristoph Bluhm, Sebastian Bluhm, Stefan Priebe
> Aufsichtsrat: Prof. Dr. iur. Winfried Huck (Vorsitzender)
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel