[pve-devel] [PATCH] Adds configuration of disk io op/s and byte/s limits

[Alexandre DERUMIER]

Hi Dietmar,

So,maybe can we use MiB/s in GUI. 

I think for a lot of people (include me ;), 1MB = 1024KB


I find good info on wikipedia, I didn't know that MiB was standardised since 2000

http://en.wikipedia.org/wiki/Mebibyte
http://en.wikipedia.org/wiki/Megabyte



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>, pve-devel at pve.proxmox.com 
Envoyé: Samedi 16 Juin 2012 14:56:36 
Objet: RE: [pve-devel] [PATCH] Adds configuration of disk io op/s and byte/s limits 

Why? GUI display MB/s (not MiB/s) 

Note: good to have you back ;-) 

> -----Original Message----- 
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com] 
> Sent: Samstag, 16. Juni 2012 09:54 
> To: Dietmar Maurer 
> Cc: Stefan Priebe - Profihost AG; pve-devel at pve.proxmox.com 
> Subject: Re: [pve-devel] [PATCH] Adds configuration of disk io op/s and 
> byte/s limits 
> 
> Hi, I'm reading the code, and I see 
> 
> values.bps_rd = drive.bps_rd / 1000000; 
> + values.bps_wr = drive.bps_wr / 1000000; 
> 
> 
> 
> 1048576 should be used instead of 1000000. 
> 
> 
> ----- Mail original ----- 
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com> 
> À: "Stefan Priebe - Profihost AG" <s.priebe at profihost.ag>, pve- 
> devel at pve.proxmox.com 
> Envoyé: Jeudi 14 Juin 2012 09:49:05 
> Objet: Re: [pve-devel] [PATCH] Adds configuration of disk io op/s and byte/s 
> limits 
> 
> > > Units is still bytes/s, which is IMHO not ideal. Should we change 
> > > that to 
> > KB/s? 
> > 
> > I would suggest MB/s. I think nobody wants to set limits in bytes or 
> > even kbytes range. 
> 
> Ok, changed to MB/s 
> 
> - Dietmar 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
> 
> 
> 
> -- 
> 
> -- 
> 
> 
> 
> 
> Alexandre D erumier 
> Ingénieur Système 
> Fixe : 03 20 68 88 90 
> Fax : 03 20 68 90 81 
> 45 Bvd du Général Leclerc 59100 Roubaix - France 
> 12 rue Marivaux 75002 Paris - France 
> 




-- 

-- 




	Alexandre D erumier 
Ingénieur Système 
Fixe : 03 20 68 88 90 
Fax : 03 20 68 90 81 
45 Bvd du Général Leclerc 59100 Roubaix - France 
12 rue Marivaux 75002 Paris - France