[pve-devel] [PATCH 1/2] fixes for qemu_block_set_io_throttle
Dietmar Maurer
dietmar at proxmox.com
Mon Jul 16 09:28:56 CEST 2012
Ok, committed.
> -----Original Message-----
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> Sent: Montag, 16. Juli 2012 07:35
> To: Dietmar Maurer
> Cc: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] [PATCH 1/2] fixes for qemu_block_set_io_throttle
>
> because qmp complain about json-int values...So I need to cast them to int.
>
> I think to_json() convert them to string.
>
>
> ----- Mail original -----
>
> De: "Dietmar Maurer" <dietmar at proxmox.com>
> À: "Alexandre Derumier" <aderumier at odiso.com>, pve-
> devel at pve.proxmox.com
> Envoyé: Lundi 16 Juillet 2012 05:51:56
> Objet: RE: [pve-devel] [PATCH 1/2] fixes for qemu_block_set_io_throttle
>
> > + vm_mon_cmd($vmid, "block_set_io_throttle", device => $deviceid, bps
> > + => int($bps), bps_rd => int($bps_rd), bps_wr => int($bps_wr), iops
> > + => int($iops), iops_rd => int($iops_rd), iops_wr => int($iops_wr));
>
> Why do you convert to int? AFAIK values are already integer?
>
> - Dietmar
>
>
>
>
> --
>
> --
>
>
>
>
>
> Alexandre D e rumier
>
> Ingénieur Systèmes et Réseaux
>
>
> Fixe : 03 20 68 88 85
>
> Fax : 03 20 68 90 88
>
>
> 45 Bvd du Général Leclerc 59100 Roubaix
> 12 rue Marivaux 75002 Paris
>
More information about the pve-devel
mailing list