[pve-devel] pve-manager add user modify functionality

Dietmar Maurer dietmar at proxmox.com
Mon Jul 4 08:44:59 CEST 2011


Hi Seth,

many thanks for the patch. I modified the patch to make it work with empty values. That needed some patches to 'pve-common' and 'pve-access-control' libs.

It is not required to use 'pvetextfield', so I replaced that with a simple 'textfield'.

IO notice that you write incorrect javascript, for eample:

--- www/manager/dc/UserEdit.js	(revision 6225)
+++ www/manager/dc/UserEdit.js	(working copy)
@@ -28,13 +28,13 @@
                 name: 'userid',
                 fieldLabel: 'Userid',
                 value: me.userid,
-                allowBlank: false,
+                allowBlank: false
             },

Such code works with most browsers, but Microsoft decided to be a PITA and
so IE fails on such code.

I am a bit unhappy with the current 'lock/unlock' API. I guess it would be much easier when we replace 
that with a simple 'enable' flag?

Concerning the UserEdit Dialog, we need the following:

- allow to specify the expiration date
- allow to specify the groups a user belongs too

what do you think?

- Dietmar



More information about the pve-devel mailing list