[pve-devel] r5477 - qemu-server/pve2/PVE/API2/Qemu

svn-commits at proxmox.com svn-commits at proxmox.com
Wed Feb 2 10:39:55 CET 2011


Author: dietmar
Date: 2011-02-02 10:39:55 +0100 (Wed, 02 Feb 2011)
New Revision: 5477

Modified:
   qemu-server/pve2/PVE/API2/Qemu/VNC.pm
Log:


Modified: qemu-server/pve2/PVE/API2/Qemu/VNC.pm
===================================================================
--- qemu-server/pve2/PVE/API2/Qemu/VNC.pm	2011-02-02 09:10:52 UTC (rev 5476)
+++ qemu-server/pve2/PVE/API2/Qemu/VNC.pm	2011-02-02 09:39:55 UTC (rev 5477)
@@ -47,7 +47,6 @@
 	my $rpcenv = PVE::RPCEnvironment::get();
 
 	my $user = $rpcenv->get_user();
-	# fixme: create ticket witch short timeout
 	my $ticket = PVE::AccessControl::assemble_ticket($user);
 
 	my ($vmid) = $param->{vmid} =~ m/^(\d+)$/; #untaint
@@ -64,8 +63,10 @@
 	    $remip = PVE::Cluster::remote_node_ip($node);
 	}
 
-	# fixme: select fastest chipher (none?)
-	my $remcmd = $remip ? ['/usr/bin/ssh', '-T', '-o', 'BatchMode=yes', $remip] : [];
+	# NOTE: kvm VNC traffic is already TLS encrypted,
+	# so we select the fastest chipher here (or 'none'?)
+	my $remcmd = $remip ? ['/usr/bin/ssh', '-T', '-o', 'BatchMode=yes',
+			       '-c', 'blowfish-cbc', $remip] : [];
 
 	my $timeout = 10; 
 



More information about the pve-devel mailing list