[pve-devel] virtiodisk ordering bug in current implementation + proposal for new qemu device syntax

Alexandre DERUMIER aderumier at odiso.com
Mon Aug 29 15:23:47 CEST 2011

ok, I don't know it was so easy :) 

Then it's ok for me, I'll try to write all the code by small commits, I think I'll have time this september. 

I'll try to have the code as clean as possible. (but i'm not so expert than you in perl ;) 

Thanks to have take time to respond to my mails , I imagine you have a lot of work to finish proxmox2. 
(By the way, you have done a wonderful work with cluster and extjs interface is very clean ). 

So , let's go to code . 

I'll keep you in touch next week with my firsts git patchs ;) 

Best Regards, 


----- Mail original -----

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 29 Août 2011 15:11:05 
Objet: RE: virtiodisk ordering bug in current implementation + proposal for new qemu device syntax 

> I just propose a branch to not break your work on trunk. 

You can't break my work, because you do not have write access ;-) 

You can simple make a local branch (that is what git is for). 

> Would you like I commit directly ? or did you want i send you patchs and you 
> make the commits ? 

OK, let me summarize how it is supposed to work: 

1.) make a local git branch to work on 
2.) commit your changes to that local branch 
3.) rebase your local branch if something changes on master 
4.) send a patch using 'git format-patch' 
5.) send the patch to the devel list using 'git send-email' 

I will then include it using 'git am' (or reject if something is missing). 

We need to test and document that workflow. Just tell 
me if you need help - I have a good book about git here ;-) 

- Dietmar 


	Alexandre Derumier 
Ingénieur système 
e-mail : aderumier at odiso.com 
Tél : +33 (0)3 20 68 88 90 
Fax : +33 (0)3 20 68 90 81 
45 Bvd du Général Leclerc 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20110829/bd4da748/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aderumier.vcf
Type: text/x-vcard
Size: 183 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20110829/bd4da748/attachment.vcf>

More information about the pve-devel mailing list