[pve-devel] virtiodisk ordering bug in current implementation + proposal for new qemu device syntax

[Alexandre DERUMIER]

Yes, i send you the subs, just to tell you it's not so hard ;)

but I agree with you, we need first rewrite device assignement with new device syntax.

So I'll wait you have done the job, before submit the patchs.

maybe a git branch could be useful for that ?



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 29 Août 2011 13:17:06 
Objet: RE: virtiodisk ordering bug in current implementation + proposal for new qemu device syntax 

> ok, for hotplug, it will be very small code. 
> 
> I just send some command to qemu monitor (like to add a cd to cdrom drive). 
> 
> basicly i use 4 new subs 
> 
> 1 to add device, 1 to remove device, 1 to parse pci devices to verify is 
> add/delete had correctly work, 1 for generated disk device command line 

It is a bit hard to tell what that code is for. It would be great if you 

a.) send patches which could be applied to the current code 
b.) split them into reasonable small commits with corresponding changelog (git is great for that) 
c.) use git to format the patches 

Also, my initial suggestion was to work on correct pci address assignment first, and new device syntax. 

Sorry if that sounds a bit complex - I just try to keep efforts minimal. 

- Dietmar 





-- 

-- 




	
	Alexandre Derumier 
Ingénieur système 
e-mail : aderumier at odiso.com 
Tél : +33 (0)3 20 68 88 90 
Fax : +33 (0)3 20 68 90 81 
45 Bvd du Général Leclerc 
59100 ROUBAIX - FRANCE 













-------------- next part --------------
A non-text attachment was scrubbed...
Name: aderumier.vcf
Type: text/x-vcard
Size: 183 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20110829/97d61230/attachment.vcf>