[pmg-devel] applied: [PATCH widget-toolkit] object grid: fix onlineHelp setting from editorConfig for row editors

[Dominik Csapak]

On 2/25/25 18:12, Thomas Lamprecht wrote:
> Am 25.02.25 um 15:16 schrieb Dominik Csapak:
>> In our row editors helpers, we unconditionally set onlineHelp from
>> 'opts.onlineHelp', even if it's undefined.
>>
>> Later we use 'Ext.apply' to set first the editorConfig defaults, then
>> the 'rowdef.editor' settings. In javascript, the objects
>>
>> {} and
>> { foo: undefined }
>>
>> are not the same, so Ext.apply overwrites the default from editorConfig
>> with that from the row definition, also for undefined.
>>
>> This means if we have a default onlineHelp in editorConfig and none in
>> the add_*_row options, we would not show it.
>>
>> To fix it, check if 'opts.onlineHelp' is truthy before setting it in
>> the row definition. This should not happen for other options used
>> from the row helper options, since those are nested
>> (Ext.apply does not work recursively)
>>
>> This fixes a regression in pmg-gui, where we set a default onlineHelp
>> for e.g. the Mail Proxy Options which would not show up anymore.
>>
>> Note: PMG is the only product where we used this pattern, so this
>> was not visible anywhere in PVE or PBS.
>>
>> Fixes: 7d16f8b (object grid: allow to pass online help to row editors)
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   src/grid/ObjectGrid.js | 20 +++++++++++++++-----
>>   1 file changed, 15 insertions(+), 5 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> we might need to start a policy for where patches for common repos should
> (additionally) get send to to allow slightly simpler noticing then.
> For now always adding pve-devel to cc for widget-toolkit patches might
> be simple enough.

makes sense to me, I actually thought about doing that, but then decided against that, since it's a
pmg visible change only and I though that currently the patch would be more visible on
pmg-devel anyway. But noted, widget-toolkit will get a cc on pve-devel in the future.

Thanks!