[pmg-devel] [PATCH pmg-api/pmg-gui v2 0/6] DKIM sign mails generated by PMG itself.

Stoiko Ivanov s.ivanov at proxmox.com
Tue Feb 25 16:01:56 CET 2025


supersedes:
https://lore.proxmox.com/pmg-devel/20250225102656.413135-1-s.ivanov@proxmox.com/T/#u
https://lore.proxmox.com/pmg-devel/20250224232451.399803-1-s.ivanov@proxmox.com/T/#t

v1->v2:
* add pattern, and lenght restriction on from-header format (patch 1)
* use the default setting of 'Proxmox Mail Gateway <postmaster>' everywhere
  instead of special-casing
* change the dkim-signing to not die when receiving an empty or domain-less
  envelope-sender (I only tested the positive case yesterday, where signing
  source was the header) - keep in mind that the effect was a warning in
  the journal, which is now a info
* add the minimal GUI-patch to the series

I kept patch 1/1 seperately, mostly due to the change being used in all
3 following patches (and since the commit-message as to why the change
should not cause regression grew rather large)
I'm fine with all 3 patches being squashed together if this seems better
to anyone.

Thanks very much to Maximilano and Dominik for the feedback provided

pmg-api:
Stoiko Ivanov (6):
  config: add admin-mail-from key
  reports: use admin-mail-from as from header
  smtp-engine: use admin-mail-from as from header for bounces
  ruledb: use admin-mail-from where sensible
  dkim: signer: log info instead of die'ing when missing domain
  reinject_local_mail: sign mails with DKIM based on header

 src/PMG/Backup.pm        |  2 +-
 src/PMG/CLI/pmgreport.pm |  2 +-
 src/PMG/Config.pm        |  7 +++++++
 src/PMG/DKIMSign.pm      | 10 ++++++++--
 src/PMG/Quarantine.pm    |  1 +
 src/PMG/RuleDB/Notify.pm |  8 ++++----
 src/PMG/SMTP.pm          |  7 ++++---
 src/PMG/Utils.pm         | 15 +++++++++++++++
 src/bin/pmg-smtp-filter  |  1 +
 9 files changed, 42 insertions(+), 11 deletions(-)

pmg-gui:
Stoiko Ivanov (1):
  configuration: options: add admin-mail-from row.

 js/SystemOptions.js | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.39.5





More information about the pmg-devel mailing list