[pmg-devel] [PATCH pmg-api/pmg-gui] expand TLS Destination Policy

Dominik Csapak d.csapak at proxmox.com
Tue Mar 17 12:41:50 CET 2020

On 3/17/20 12:28 PM, Stoiko Ivanov wrote:
> Thanks for the review and tests!
> On Wed, Mar 11, 2020 at 03:53:05PM +0100, Dominik Csapak wrote:
>> looked at and tested, works so far and code looks good
>> 2 points i want to mention:
>> 1. postfix talks about the syntax [ipv6:<ipv6-address>]
>> and says ipv6 adresses must be written this way, but it does not
>> actually enforce it. i guess it would be good to also allow
>> that syntax just for completeness (e.g. if users edit the
>> transport map manually) but this is more tangetially related
> good point! (will send an updated v2 with the whole /etc/pmg/transport
> parsing adapted - to support it there as well)
>> 2. in patch pmg-api 2/2 you could have both domain and destination
>> filled in during the 'read_tls_policy' sub, instead of the api
>> call, but since we want to remove this anyway, it does not hurt
> took a look - see the point of 1 line in Config.pm vs. 2 lines in
> API/Transport.pm - but OTOH the backward-compatibility code is quite a few
> lines more - and that way it's kept to one source-file - which I would
> prefer.
> so would leave that as is if you're ok with it?

fine with me

thanks :)

More information about the pmg-devel mailing list