[pmg-devel] #2438 add lmtp support in pmg

[Stoiko Ivanov]

Hi,

sorry for the long wait for feedback!

On Sun, 05 Jan 2020 22:07:35 +0100
pmg-devel at j-z.it wrote:

> Hi,
> 
> i have just send v2 of the lmtp patch (3 parts).
> 
> All your comments should now be adressed.
> In my testing environment it works perfectly.

I quickly gave it a spin here, by setting up a dovecot in my test environment
and setting that as default relay and as a transport for a particular domain

It does work quite nicely!
Huge thanks for your time and effort!

I did find a few cosmetic nits (will write them as replies to the 
individual patches) - but I think we could address them as fixups
following your commits.

> 
> But i can´t successfully build the pmg-docs package, but i think this was the easiest patch.
Content-wise it looks good - the trick would have been to:
* patching pmg-api
* patching pmg-docs/gen-pmg.conf.5-opts.pl (adding the relayprotocol key)
* copying it to /usr/share/pmg-doc-generator/gen-pmg.conf.5-opts.pl
* build pmg-api and install the resulting deb
* running `make update` inside the pmg-docs repo (this generates the updated
  'pmg.mail-relaying-conf-opts.adoc' and 'pmg.conf.5-opts.adoc'
* adapting the remaining documentation ('pmgconfig.adoc')
* building and installing pmg-docs and pmg-doc-generator

which is quite the long procedure - and something we can do here (until
we come up with a nicer interface)


> 
> Could you please check the v2 version and give me some feedback?
> 
> I think it could be ready for pmg-test repository.
> 
> The CLA is in the road ;)
Thanks - AFAIK we received it by now!

> 
> Thank you,
> Julian
> 
> Am 13. Dezember 2019 09:22:33 MEZ schrieb Stoiko Ivanov <s.ivanov at proxmox.com>:
> >Hi,
> >
> >On Thu, 12 Dec 2019 22:18:23 +0100
> >Julian Zehnter <pmg-devel at j-z.it> wrote:
> >  
> >> Hi,
> >> 
> >> thank you for your feedback, review and testing.
> >> 
> >> I will put your feedback on the individual patches in a new v2 patch
> >> and will test it on my mailgate-dev according your suggestion.
> >> 
> >> i will come back in the next days with v2.  
> >
> >Perfect - Looking forward!
> >  
> >> 
> >> Regards,
> >> Julian  
> >
> >
> >Thank you and best Regards,
> >stoiko
> >  
> >> 
> >> Am 10.12.2019 um 11:19 schrieb Stoiko Ivanov:  
> >> > Hi,
> >> >
> >> > Thank you very much for your contribution!
> >> >
> >> >
> >> > On Mon,  9 Dec 2019 20:59:55 +0100
> >> > Julian Zehnter <pmg-devel at j-z.it> wrote:
> >> >    
> >> >> Hi,
> >> >>
> >> >> this is my first trial to implement the lmtp support in bugzilla  
> >#2438.  
> >> >> I just dive into the code an adapt some parts for lmtp.
> >> >>
> >> >> Mybe you can check the examine the patches and give me some hints  
> >of missing parts.  
> >> >> How can i check the changes in a test environment?    
> >> > We gave them a quick look - noticed to small glitches (I'll point  
> >them  
> >> > out in reply to the individual patches).
> >> >
> >> > We'd still need a signed CLA to be able to apply it, see:
> >> >  
> >https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright  
> >> > for details.
> >> >
> >> > I'll apply and test them locally and provide some feedback here -  
> >maybe you could  
> >> > wait with a v2.
> >> >    
> >> >> The perl files seems to be easily to replace.    
> >> > You can edit them inplace (or run `make deb`; and install the .deb  
> >package afterwards)  
> >> > Afterwards you'd need to restart the affected services (pmgproxy,  
> >pmgdaemon) and  
> >> > run pmgconfig sync (in this case).
> >> >    
> >> >> Regarding the js files, i don´t know.    
> >> > Probably again the easiest is to run `make deb` and install the  
> >pmg-gui package  
> >> > running make install as root in the top-directory (however this  
> >might leave your  
> >> > system in a rather odd state (until a package upgrade overrides it)
> >> > I personally always use the deb route for the GUI.
> >> >
> >> >    
> >> >> Thanks und Greetings,
> >> >> Julian    
> >> > Thank you!
> >> > stoiko
> >> >
> >> >    
> >>