[pmg-devel] [PATCH pmg-api] add depdends on gpg

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 6 07:54:09 CEST 2019

On 05.09.19 16:36, Stoiko Ivanov wrote:
> On Thu, 5 Sep 2019 16:24:13 +0200
> Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
>> On 03.09.19 12:21, Stoiko Ivanov wrote:
>>> running `sa-update` without explicitly specifying '--no-gpg' invokes the `gpg`
>>> binary. PMG::API2::Spamassassin uses `sa-update` for updating spamassassin
>>> rulesets.
>>> Since the functionality is broken when gpg is not installed (and we don't want
>>> to disable gpg-verification by default) this patch adds gpg as Depends.  
>> as proxmox-spamassassin ships sa-updates, why not add there a Depends/Recommends?
> Thought about this initially too - but then checked debian's spamassassin package,
> which has neither depends nor recommends. The shipped cronjob for sa-update does also
> not really rely on it (it exits if gpg is not found...)
> After a quick chat with Dominik we came to the conclusion, that if pmg-api uses the
> sa-update (without explicitly disabling gpg), then it's the package which depends
> on gpg in order to function correctly.

But, that's not how it works.
* If it'd use gpg directly itself -> dependency
* if it can use gpg optionally, but directly, and that allows to do much more
  (essential things) -> Recommends
* if it can use gpg optionally, but directly, and that allows to do a few things
  more -> Recommends

Spamassasin, at least our one, has none of those, and at least a Suggest is
warranted for sure, IMO, maybe even Recommends.

> OTOH adding a Recommends on gpg to proxmox-spamassassin does not sound wrong either..
> Not too attached to either solution - and will gladly send the patch for
> proxmox-spamassassin if we agree on this way.

I'll opt for the third, which just hit me as "correct solution":

How does it works for ISO installations? The answer: the ISO ships it by explictily
installing it.

So just let's do the same and add it to the dab Makefile:

(I'll do so and update the template)

More information about the pmg-devel mailing list